-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port grakn sudoku-solver example #147
base: master
Are you sure you want to change the base?
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add review so that we change the package structure to the standard two-level package
c1229d5
to
f696a4d
Compare
Blocked: The sudoku tests will fail till it's run against the improved reasoner planner. |
Ok so I've had a look over this, questions:
|
games/sudoku/requirements.txt
Outdated
@@ -0,0 +1 @@ | |||
typedb-client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should pin a verison number
…d argv[2] as typedb address
If we use rules, our planner can't tell the difference because of how the AnswerCountEstimator estimates inferred things.
As of now, we do. Without it we don't pick the best plan in the top level. |
What is the goal of this PR?
Port the grakn sudoku-solver to typeql and add as an example.
Distill the schema & queries to the most basic form which also works with the reasoner planner's cost model.
What are the changes implemented in this PR?