Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collectFirst to the NonEmptyCollection interface #4275

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add collectFirst to the NonEmptyCollection interface #4275

merged 1 commit into from
Jul 28, 2022

Conversation

DavidGregory084
Copy link
Member

@DavidGregory084 DavidGregory084 commented Jul 28, 2022

This work was initially done on PR #4193 to support the cats.data.HashMap implementation, but now that that PR is being retargeted onto cats-collections I'd like to make sure this change isn't lost.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@armanbilge armanbilge added this to the 2.9.0 milestone Jul 28, 2022
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armanbilge
Copy link
Member

Merging since I assume the snapshot will unblock the PR retargeting. Thanks for all your work on that btw.

@armanbilge armanbilge merged commit ba69c19 into typelevel:main Jul 28, 2022
@DavidGregory084 DavidGregory084 deleted the nonempty-collectfirst branch July 28, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants