-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Curated projects #272 #274
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on. I like the direction. I am so sorry it took so long for me to review this.
Some style suggestions:
- I like the categories. I don't think the descriptions add much beyond the titles. Maybe we could live without those.
- Since we have the star data, we could probably use a star emoji or reuse some badge code somewhere.
- We should make the library titles larger than the library descriptions.
- We have a lot of great logos. It would be neat if
ico-repo
could be replaced with those. Maybe if we adopted a Typelevel convention of a logo.svg file in a fixed place, the star-scraping script could find those, too. Would give the page some visual pop.
I depend on the Docker container to install all the dependencies. I had a hard time building this, so I opened #280. The one problem I still had was You must use Bundler 2 or greater with this lockfile.
I'm not very good with bundler, so I just deleted Gemfile.lock
and moved on, but I'm pretty sure there's a better way.
We'll need to include catbird from #282. |
And case-insensitive from #283 |
Just to note down an update on where I'm at with this. I mainly lost interest as it was a PITA working with Jekyll, switched focus for the time being, but hope to pick this up again at some point in the not to distant future. |
If you're struggling with the Ruby dependency management, I have had success with the Docker container. If you're struggling with the Jekyll itself, well, you and me both. In any event, we appreciate it. |
Further on jekyll: any time I've proposed alternatives to Jekyll on various Typelevel projects, people stand up for how easy it is to deploy on gh-pages. If we were to do a more radical overhaul, we'd need an answer to that. Paradox has been my favorite static site generator for the JVM (i.e., no extra install), but I think it's more geared toward docs than blogs. I use and like Hugo on some other sites, but there would be CI work, and the syntax is less familiar to people. But that's all probably discussion for another ticket. |
In progress #272 .
TODO list:
:robot:
)In progress preview