-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: first approach to find existing eslint config #724
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,40 @@ | ||||||
import { fsFileSystem } from "../adapters/fsFileSystem"; | ||||||
import { GlobAsync } from "../adapters/globAsync"; | ||||||
import { ResultStatus, ResultWithDataStatus } from "../types"; | ||||||
import { ESLintConfiguration } from "./findESLintConfiguration"; | ||||||
|
||||||
export type FindExistingESLintConfigurationDependencies = { | ||||||
globAsync: GlobAsync; | ||||||
}; | ||||||
|
||||||
export const findExistingESLintConfiguration = async ( | ||||||
dependencies: FindExistingESLintConfigurationDependencies, | ||||||
): Promise<ResultWithDataStatus<ESLintConfiguration | string[]>> => { | ||||||
const globResult = await dependencies.globAsync(".eslintrc.{js,json,yaml}"); | ||||||
const packageContent = await fsFileSystem.readFile("package.json"); | ||||||
if (!(globResult instanceof Error)) { | ||||||
return { | ||||||
data: globResult, | ||||||
status: ResultStatus.Succeeded, | ||||||
}; | ||||||
} | ||||||
if (globResult instanceof Error && packageContent instanceof Error) { | ||||||
return { | ||||||
errors: [globResult, packageContent], | ||||||
status: ResultStatus.Failed, | ||||||
}; | ||||||
} | ||||||
if (globResult instanceof Error && typeof packageContent === "string") { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit, just marking this down because it confused me at first 😛
Suggested change
|
||||||
const parsedPackage: Record<string, unknown> = JSON.parse(packageContent); | ||||||
if (parsedPackage.hasOwnProperty("eslintConfig")) { | ||||||
return { | ||||||
data: parsedPackage.eslintConfig as ESLintConfiguration, | ||||||
status: ResultStatus.Succeeded, | ||||||
}; | ||||||
} | ||||||
} | ||||||
return { | ||||||
errors: [new Error("Could not find an existing ESLint Config")], | ||||||
status: ResultStatus.Failed, | ||||||
}; | ||||||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, yeah, the return type of this is what I was curious about... At first, I was thinking thinking the calling code will want to know whether this is an npm package style file or an ESLint one. For example, what happens if someone does something like
--config ./packages/somewhere/package.json
, and wants this to work on theeslintConfig
in that nested file?But, it's really only
package.json
files that have the oddeslintConfig
member... Maybe the writing code would always want to override an existingeslintConfig
in the output file if that output file's name ends with"package.json"
? What do you think