Update typesense-js dependency to 2.0.0-14 and fix Ubuntu 24.04 issues on CI #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add system dependencies required for running puppeteer tests - install chromium-browser for headless testing - configure artifact upload for screenshots
- replace manual chrome installation with `browser-actions/setup-chrome` - add `xvfb-run` for headless browser testing - configure chrome path in `jest-puppeteer.config.js` - ensure screenshots are always uploaded even on test failure
tharropoulos
changed the title
jasonbosco
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What is this?
This PR addresses CI failures occurring on
ubuntu-latestandubuntu-24.04runners. The current Puppeteer setup doesn't work properly on these environments, causing our e2e tests to fail. This update properly configures the necessary system dependencies and Chrome installation to ensure our tests run reliably across all Ubuntu versions.Changes
CI Environment Setup:
In
.github/workflows/tests.yml:libdbus-1-3,libgdk-pixbuf2.0-0,libgtk-3-0if: always()for screenshot artifacts to capture even on failuresIn
jest-puppeteer.config.js:Dependency Updates:
2.0.0-14for better compatibilityContext
Our CI pipeline was failing on newer Ubuntu versions due to missing system dependencies and incorrect Chrome configuration. These changes ensure our tests run consistently across all supported Ubuntu versions in GitHub Actions.
PR Checklist