Index annotations #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxi17
reviewed
Jun 23, 2020
| @@ -171,7 +172,7 @@ public boolean contains(JsonElement element) { | |||
| public int size() { | |||
| return elements.size(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This diff file is too cluttered with empty spaces.
| @@ -233,9 +233,11 @@ public byte getAsByte() { | |||
| return isNumber() ? getAsNumber().byteValue() : Byte.parseByte(getAsString()); | |||
| } | |||
|
|
|||
| //getAsString returns a String of minimum length 1, charAt(0) is safe | |||
| @SuppressWarnings("index:argument.type.incompatible") | |||
There was a problem hiding this comment.
Why using a @MinLen annotation to express what you said here doesn't work?
| @@ -274,10 +286,12 @@ static Type getGenericSupertype(Type context, Class<?> rawType, Class<?> toResol | |||
| * | |||
| * @param supertype a superclass of, or interface implemented by, this. | |||
| */ | |||
| /*Missing annotation in JDK in @MinLen(1) getUpperBounds() of WildcardType #5*/ | |||
There was a problem hiding this comment.
Remember to delete these comments once missing JDK annotations are added.
| @@ -130,7 +130,8 @@ public ConstructorConstructor(Map<Type, InstanceCreator<?>> instanceCreators) { | |||
| * Constructors for common interface types like Map and List and their | |||
| * subtypes. | |||
| */ | |||
| @SuppressWarnings("unchecked") // use runtime checks to guarantee that 'T' is what it is | |||
| //getActualTypeArguments may return an empty array #1 #2 | |||
There was a problem hiding this comment.
So is this a possible bug in Gson?
| @@ -78,13 +80,15 @@ protected TypeToken() { | |||
| * Returns the type from super class's type parameter in {@link $Gson$Types#canonicalize | |||
| * canonical form}. | |||
| */ | |||
| //getActualTypeArguments() may return an empty array as per documentation | |||
There was a problem hiding this comment.
Again, can you write a test case in which unexpected behavior happens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Maxi17 Index annotations are added. Please review.