This repository has been archived by the owner on Jun 16, 2024. It is now read-only.
Cache latest versions in Redis #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- issue typings#35 - add files - `src/api/routes/support/redis.ts` - `src/worker/jobs/support/redis.ts` - add libraries - `lodash` - `redis` - define `redisKey` - {source}:{name} acquire package info with precedence from Redis when `version/latest`
| @@ -121,6 +122,16 @@ export function getMatchingVersions (source: string, name: string, version: stri | |||
| * Retrieve the latest available version. | |||
| */ | |||
| export function getLatest (source: string, name: string, version?: string) { | |||
| return getVersionInRedis(source, name).then((data) => { | |||
There was a problem hiding this comment.
This doesn't work with the version operator. If it's in Redis, searching by version will break.
|
I made some comments, but I'd invert how control occurs here. Have the API check Redis first, then fallback to DB and persist the result. Only have jobs invalidating entries. This allows deployments and re-indexing to occur independent of the cache layer. Otherwise any changes in the schema need to re-index all jobs. |
|
Thank you for posting comments :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
issue
#35
added files
src/api/routes/support/redis.tssrc/worker/jobs/support/redis.tsadded libraries
lodashredisredisKey
I define redisKey is
{source}:{name}schema (
version/latest)in redis
@blakeembrey In the case of
undefined, a property disappears in the schema. This is because my Implementation usesJSON.stringify. When the property disappears, is the influence given?I think that we should create the environment to write a test.
thanks.