Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socialhub-svg:1.0.0 #467

Closed
wants to merge 1 commit into from
Closed

socialhub-svg:1.0.0 #467

wants to merge 1 commit into from

Conversation

Bi0T1N
Copy link
Contributor

@Bi0T1N Bi0T1N commented Mar 23, 2024

I am submitting

  • a new package
  • an update for a package

Description: Explain what the package does and why it's useful.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@reknih
Copy link
Member

reknih commented Mar 25, 2024

Thank you for your submission!

The problems we have to address are largely IP-related:

Although socialhub would be an acceptable name on its own, I found active trademarks on it in advertising (Nice 38) in the US, China, and Italy, as far as I can see, each by a different company. There is also the very similar Socialhub+ trademark for digital services (Nice 42) in China. Lastly, there is a German company that uses that name in trade. All in all, I think that this package exposes you and us to too much risk and should be renamed.

The other point is on the license: You license the package as MIT, but it has to be made clear somewhere (best place is the README) that the logos are the property of their respective trademark holders and that you are neither officially endorsed by them nor claim any ownership over the marks.

license = "MIT"
description = "A Typst library for Social Media references with scalable vector graphics icons."
keywords = ["social", "media", "icons", "svg"]
exclude = ["examples"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and I noticed that you could add the categories = ["components"] key to make your package more discoverable.

@reknih reknih added the new A new package submission. label Mar 26, 2024
@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Mar 29, 2024

Although socialhub would be an acceptable name on its own, I found active trademarks on it in advertising (Nice 38) in the US, China, and Italy, as far as I can see, each by a different company. There is also the very similar Socialhub+ trademark for digital services (Nice 42) in China. Lastly, there is a German company that uses that name in trade. All in all, I think that this package exposes you and us to too much risk and should be renamed.

I just used the name from my other PR at #218 but you're correct if there are some trademarks it's better to rename it and using socialhub was a bad idea. I'll come up with another name in the next days.

The other point is on the license: You license the package as MIT, but it has to be made clear somewhere (best place is the README) that the logos are the property of their respective trademark holders and that you are neither officially endorsed by them nor claim any ownership over the marks.

Thanks, I'll also add and source for every SVG icon. Better safe than sorry.

@laurmaedje laurmaedje added the waiting-on-author Pull request waits on author label Apr 1, 2024
@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Apr 7, 2024

What about sociallist ,sociallistings, social-listings (all short: sl) or socialmedialistings (short: sml)? Would one of them be accepted?

@laurmaedje laurmaedje removed the waiting-on-author Pull request waits on author label Apr 8, 2024
@reknih
Copy link
Member

reknih commented Apr 8, 2024

All of these names are rather descriptive - they are not in the spirit of our naming rules. Given that I approved socialhub in 218 I am willing to let it slide. However, we will remove both packages if we receive a complaint from one of the rights holders of the name.

I would recommend that you rename both packages in a future update.

Given this, we can merge this once the build failure is fixed.

@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Apr 9, 2024

Well, it's kinda hard to come up with a name that isn't descriptive as these icons are very special and have a single purpose. A landlord won't use them for his monthly rental invoice but maybe for his own CV/project showcase (exception: you're the trademark holder and writing your letters in Typst).
But names containing trademark or icons will also be to descriptive or too general (trademarkhub will also cause law problems). And I don't intend to have icons for every website in the world - just the big ones you might want to use in your CV.

@JKRhb
Copy link
Contributor

JKRhb commented Apr 11, 2024

Not sure if it is relevant for this version anymore, but how about a name like socio or iconic?

@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Apr 11, 2024

Not sure if it is relevant for this version anymore, but how about a name like socio or iconic?

Thanks - these are good suggestions! I like iconic 👍
This motivated me to look for an acronym: salmon for SociAL Media icONs

@reknih: Would it be okay to use one of these two? Maybe even combined: iconic-salmon (that's what I'd prefer! 😎)

@laurmaedje
Copy link
Member

@Bi0T1N Any of those three would be fine.

@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Apr 12, 2024

I opened a new PR #536 with the adjusted typst.toml, new name and a trademark disclaimer.

@Bi0T1N Bi0T1N closed this Apr 12, 2024
@Bi0T1N Bi0T1N deleted the socialsvg branch April 20, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants