-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socialhub-svg:1.0.0 #467
socialhub-svg:1.0.0 #467
Conversation
Thank you for your submission! The problems we have to address are largely IP-related: Although The other point is on the license: You license the package as MIT, but it has to be made clear somewhere (best place is the README) that the logos are the property of their respective trademark holders and that you are neither officially endorsed by them nor claim any ownership over the marks. |
license = "MIT" | ||
description = "A Typst library for Social Media references with scalable vector graphics icons." | ||
keywords = ["social", "media", "icons", "svg"] | ||
exclude = ["examples"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, and I noticed that you could add the categories = ["components"]
key to make your package more discoverable.
I just used the name from my other PR at #218 but you're correct if there are some trademarks it's better to rename it and using
Thanks, I'll also add and source for every SVG icon. Better safe than sorry. |
What about |
All of these names are rather descriptive - they are not in the spirit of our naming rules. Given that I approved I would recommend that you rename both packages in a future update. Given this, we can merge this once the build failure is fixed. |
Well, it's kinda hard to come up with a name that isn't descriptive as these icons are very special and have a single purpose. A landlord won't use them for his monthly rental invoice but maybe for his own CV/project showcase (exception: you're the trademark holder and writing your letters in Typst). |
Not sure if it is relevant for this version anymore, but how about a name like |
Thanks - these are good suggestions! I like @reknih: Would it be okay to use one of these two? Maybe even combined: |
@Bi0T1N Any of those three would be fine. |
I opened a new PR #536 with the adjusted |
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE