Fix bbmain to correctly handle #! files #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
confirmed that this fixes plan 9 issues. 1.16 i'm mystified. |
|
but in any event afaict this change is unrelated to those build failures. |
hugelgupf
force-pushed
the
fixforplan9
branch
9 times, most recently
from
4b3065b
to
dca5793
Compare
|
@rminnich what's the verdict? |
|
oh geez, sorry, I just realized this had not gone in. Let me take a look. |
rminnich
force-pushed
the
fixforplan9
branch
from
70913fd
to
49bec40
Compare
|
we also need it for VFAT volumes .. |
gobusybox binaries can now be invoked by creating regular files instead of symlinks, and those files need to contain: \#!/abs/path/to/bb #!gobb!# More explanation in code comments. This is needed for Plan 9 and file systems that do not support symlinks. Co-authored-by: Chris Koch <[email protected]> Signed-off-by: Ronald G. Minnich <[email protected]> Signed-off-by: Chris Koch <[email protected]>
rminnich
force-pushed
the
fixforplan9
branch
from
49bec40
to
db2286e
Compare
|
well, that build went badly :-) |
hugelgupf
reviewed
Nov 12, 2023
| @@ -3,6 +3,8 @@ set -eux | |||
|
|
|||
| # This one hasn't been migrated to the go test yet. | |||
| (cd ./test/requestconflict && ./test.sh) | |||
|
|
|||
| (cd ./src/cmd/makebb && GO111MODULE=on go build .) | |||
| (cd ./test && go test --makebb=../src/cmd/makebb/makebb -v) | |||
There was a problem hiding this comment.
tests are not shell files anymore, they're now a Go test in ./test directory -- add your new kind of test there instead of as a shell file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Plan 9.
Signed-off-by: Ronald G. Minnich [email protected]