files: fix invalid syntax cases

Signed-off-by: Chris Koch <[email protected]>

uroot/uroot.go

@@ -395,7 +395,12 @@ func ParseExtraFiles(logger ulog.Logger, archive *initramfs.Files, extraFiles []
 		var src, dst string
 		parts := strings.SplitN(file, ":", 2)
 		if len(parts) == 2 {
-			// treat the entry with the new src:dst syntax
+			if len(parts[0]) == 0 {
+				return fmt.Errorf("%w: invalid extra files %q", os.ErrInvalid, file)
+			}
+			if len(parts[1]) == 0 {
+				return fmt.Errorf("%w: invalid extra files %q", os.ErrInvalid, file)
+			}
 			src = filepath.Clean(parts[0])
 			dst = filepath.Clean(parts[1])
 		} else {

uroot/uroot_test.go

@@ -150,7 +150,6 @@ func TestCreateInitramfs(t *testing.T) {
 				itest.IsEmpty{},
 			},
 		},
-		/* TODO: case is broken.
 		{
 			name: "files invalid syntax 1",
 			opts: Opts{
@@ -159,13 +158,11 @@ func TestCreateInitramfs(t *testing.T) {
 					":etc/somefile",
 				},
 			},
-			//errs: []error{os.ErrExist},
+			errs: []error{os.ErrInvalid},
 			validators: []itest.ArchiveValidator{
 				itest.IsEmpty{},
 			},
 		},
-		*/
-		/* TODO: case is broken.
 		{
 			name: "files invalid syntax 2",
 			opts: Opts{
@@ -174,12 +171,11 @@ func TestCreateInitramfs(t *testing.T) {
 					somefile + ":",
 				},
 			},
-			//errs: []error{os.ErrExist},
+			errs: []error{os.ErrInvalid},
 			validators: []itest.ArchiveValidator{
 				itest.IsEmpty{},
 			},
 		},
-		*/
 		// TODO: files are directories.
 		{
 			name: "file conflicts with init",