Fix race condition in test

Signed-off-by: Chris Koch <[email protected]>
u-root · Jan 19, 2024 · 53ddfa8 · 53ddfa8
1 parent a64e72f
commit 53ddfa8
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/cmd/mkuimage/main_test.go b/cmd/mkuimage/main_test.go
@@ -225,6 +225,7 @@ func TestUrootCmdline(t *testing.T) {
 				sum1, sum2 []byte
 				errs       [2]error
 				wg         = &sync.WaitGroup{}
+				removeMu   sync.Mutex
 				remove     []string
 			)
 
@@ -243,7 +244,9 @@ func TestUrootCmdline(t *testing.T) {
 					return
 				}
 
+				removeMu.Lock()
 				remove = append(remove, f1.Name())
+				removeMu.Unlock()
 				for _, v := range tt.validators {
 					if err := v.Validate(a); err != nil {
 						t.Errorf("validator failed: %v / archive:\n%s", err, a)
@@ -259,7 +262,9 @@ func TestUrootCmdline(t *testing.T) {
 					errs[1] = err
 					return
 				}
+				removeMu.Lock()
 				remove = append(remove, f2.Name())
+				removeMu.Unlock()
 			}()
 
 			wg.Wait()