deps: upgraded dependency #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have you run the tests? https://github.com/ua-parser/uap-go?tab=readme-ov-file#testing unfortunately these aren't automated yet. Also should mention, I took a look at the mentioned vulnerabilities. Practically they aren't interesting for this package - they are all about DOS against the yaml parser, but we don't parse user-supplied yaml. I think we actually just parse the uap-core yaml at build time. That said upgrading is probably a good idea so happy to accept the upgrades, provided the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were vulernabilities in older dependencies so I have upgraded it
(GO-2020-0036)
(GO-2021-0061)
(GO-2022-0956)