Ruff does not understand contextlib.suppress
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not entirely clear when F811 started triggering on this pattern (it didn't 3 months ago but is now unhappy with this). Use `find_spec` to perform a conditional import rather than recover from a failing import. This is generally less efficient, but given it's only done at import it likely doesnt matter. - successfully importing a module takes about 65ns - successfully find_spec-ing a module takes about 280ns - unsuccessfully find_spec-ing a module takes about 21*µ*s - unsuccessfully importing a modules (then recovering) takes about 26µs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely clear when F811 started triggering on this pattern (it didn't 3 months ago but is now unhappy with this).
Use
find_specto perform a conditional import rather than recover from a failing import. This is generally less efficient, but given it's only done at import it likely doesnt matter.