Add flag for EarthScope-ready miniSEED export #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfee5
reviewed
Oct 2, 2023
|
@davidfee5 thanks for your comments. I have addressed them and if you think this looks good, we can merge! Note that the BoB factor application will be done in the StationXML creation script in the Yasur 2023 repo. Including a generalized form of that script in this repo would likely make sense but should be a separate PR I feel. |
This is done in https://github.com/liamtoney/yasur_2023/commit/79ce6526142ac998924660223f842239ed533dd2 (private repo) |
davidfee5
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option,
--earthscope, which produces miniSEED files that are ready for EarthScope upload. Namely, this means that they are in digitizer integer counts. See #1, which this PR addresses (but not completely!).One important change is the the encoding for
cube2mseedhas been changed toINT-32. Previously it wasFLOAT-64, but I don't think this makes sense for a file that is natively coming off the digitizer in counts. The default encoding forcube2mseedis an integer data type, so that supports this. The code now specifies an encoding when writing the final miniSEED files.I'm not quite sure how to handle the BoB factor. Here I've just multiplied digitizer counts by this factor. Input welcome on this!