Improve log clarity #443
Merged
Improve log clarity #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes logs easier to understand by humans. We start counting ingestion attempts at 1. We will also format all events in the json log in the same way.
lagoan
requested review from
ConnorSheremeta,
henryzhang87,
pgwillia and
piyapongch
as code owners
lib/pushmi_pullyu/cli.rb
Outdated
| PushmiPullyu::Logging.log_preservation_attempt(entity, | ||
| queue.get_entity_ingestion_attempt(entity)) | ||
| queue.get_entity_ingestion_attempt(entity) + 1) |
There was a problem hiding this comment.
Small nit: I feel like humanising the counts inside of the log_preservation_x methods would be ideal. Not a show stopper though
ConnorSheremeta
previously approved these changes
Jun 5, 2024
This commit addresses PR comments and fixes a problem with the JSON log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes logs easier to understand by humans.
We start counting ingestion attempts at 1.
We will also format all events in the JSON log with the same structure.