Unified GUI updates, part 4 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update skybox mod * Add realm helpers for applying/saving skyboxes
* Add realm skybox getter * Prevent unnecessary spawn updates when editing realms
* Groups are current saved per-player - I am currently considering adding a way to export/share groups for convenience * Move list swap button textures from mc_tutorial to mc_teacher * Fix crash when using the bring action
* Players can now only be students, teachers, or administrators * Add additional player list refresh calls * Update priv requirements for using student tools * Student notebook: no privs * Tutorial book: interact
* Add new placeholder icon to player list in teacher tool
* Add getter function for realm owners + owner string converter * Add [SPAWN] prefix to the spawn realm * Show owners of private realms dynamically instead of appending to name on realm creation * This will not change the names of private realms created before this change - their names will need to be edited manually
* Adapted from actions.lua in rubenwardy's classroom mod (https://gitlab.com/rubenwardy/classroom/-/blob/master/actions.lua) * Abstract general realm joinability checks into helper function
* Move sounds to sounds/music so that "teleport" isn't treated as music * Add new helpers for getting/setting music
|
Opening for review to merge critical patches and complete current GUI implementation. The remaining features in #234 will be added in a future PR |
19 tasks
pauldpickell
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements many of the remaining outstanding features in #231 and #234, patches some known bugs, and makes some GUI-related quality of life improvements