Implement group_add_member. #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the other parameters. implement the group_add_member call (https://freeipa.readthedocs.io/en/latest/api/group_add_member.html) in group.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i'm currently implementing my first "group" call I need,
First, I copied the
rpcfunction and createrpcContextwhich is an exact copy but instead taking a context and use it while creating thehttp.Requeststruct.For the group_add_member call itself It's very simple but I want to know your opinion about if you prefer this kind of generic function or if we create a private function like
groupAddMemberand create different functios abstracting the memberType likeGroupAddUserGroupAddGroupand so on.Oh and I also change every call to ioutil to the os package since ioutil is deprecated now !