Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastp unit test #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fastp unit test #32

wants to merge 4 commits into from

Conversation

tonykew
Copy link
Contributor

@tonykew tonykew commented Jan 18, 2024

fastp (very simple) unit test

Tony

@tonykew tonykew mentioned this pull request Jan 18, 2024
Closed
@tonykew tonykew requested a review from aebruno January 18, 2024 19:43
aebruno
aebruno requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@aebruno aebruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a tar.gz of these files and add to test_src like we do for the others.

@tonykew tonykew requested a review from aebruno January 31, 2024 21:25
@tonykew tonykew self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aebruno aebruno Awaiting requested review from aebruno

Requested changes must be addressed to merge this pull request.

Assignees

@tonykew tonykew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonykew @aebruno