Improve performance of validation of filters and raw fields. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronweeden
requested review from
eiffel777,
jpwhite4,
ryanrath,
connersaeli and
aestoltm
aaronweeden
force-pushed
the
improve-validation-performance
branch
from
3ca2730
to
b09f2fc
Compare
aaronweeden
force-pushed
the
improve-validation-performance
branch
from
b09f2fc
to
8fd9dd8
Compare
aaronweeden
force-pushed
the
improve-validation-performance
branch
2 times, most recently
from
b0901e8
to
f073b79
Compare
aaronweeden
force-pushed
the
improve-validation-performance
branch
from
f073b79
to
1dfb3a5
Compare
eiffel777
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the performance of validation of filters and raw fields by moving HTTP requests that only need to be called once out of loops.
Tests performed
These changes are covered by an existing regression test (
test_get_raw_data) that I ran by following the instructions indocs/developing.md.Types of changes
Checklist:
CHANGELOG.mdhas been updateddocs/developing.md) produces no errors.