forked from jpwhite4/xdmod-python
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with trailing slashes in xdmod_host
.
#24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronweeden
reviewed
Jun 3, 2024
aaronweeden
reviewed
Jun 3, 2024
aaronweeden
reviewed
Jun 3, 2024
aaronweeden
reviewed
Jun 3, 2024
aaronweeden
reviewed
Jun 3, 2024
aaronweeden
changed the title
Fix multiple slash problem
Fix bug with trailing slashes in Jun 4, 2024
xdmod_host
.
aaronweeden
reviewed
Jun 5, 2024
aaronweeden
reviewed
Jun 5, 2024
Co-authored-by: Aaron Weeden <[email protected]>
aaronweeden
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug when trailing slashes are in the
xdmod_host
parameter. For an example:Because this
'https://xdmod.access-ci.org/'
has a trailing slash that results in aRuntimeError: Error 404: No route found for "GET //rest/v1/warehouse/export/realms"
.Tests performed
This PR adds an automated integration test that runs every method in the API with
'https://xdmod.access-ci.org/'
. In order to make that work this PR also adds the ability to pass in an invalid URL todw_methods
.This PR also updates the sample values used when testing, specifically
'duration'
so that fewer raw data are requested and'show_progress'
so that the output is easier to read.This PR also fixes multiple style issues and reduces duplicated code.
Types of changes
Checklist:
CHANGELOG.md
has been updateddocs/developing.md
) produces no errorsxdmod-notebooks
repository as necessary, and the notebooks all run successfully