Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOPub error when showing progress with get_raw_data(). #39

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

aaronweeden
Copy link

@aaronweeden aaronweeden commented Oct 30, 2024

Description

This PR fixes the error IOPub data rate exceeded when using the show_progress=True parameter to get_raw_data() in a Jupyter notebook.

This error is visible in, for example, the machine learning example notebook from xdmod-notebooks.

This PR fixes the error by only updating the progress message every 10,000 rows rather than every single row.

This PR also does the following:

  • Make a few enhancements to the PR template.
  • Remove an extra empty line from docs/developing.md.
  • Update the regression test artifacts based on the changes to ACCESS XDMoD 11.0.

This is also backported for the 1.0.2 development version: #40.

Tests performed

Tested on my laptop following docs/developing.md.

Types of changes

  • Refactoring / documentation update (non-breaking change which does not change functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release preparation

Checklist:

  • CHANGELOG.md has been updated
  • xdmod_data/__version__.py has been updated to the next development version
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request
  • Running the automated tests (see docs/developing.md) produces no errors
  • Updates have been made to the xdmod-notebooks repository as necessary, and the notebooks all run successfully
  • The changes in this PR have been ported/backported to other branches as needed

@aaronweeden aaronweeden marked this pull request as ready for review October 30, 2024 21:34
@aaronweeden aaronweeden merged commit c9a3f57 into ubccr:main Oct 31, 2024
5 checks passed
@aaronweeden aaronweeden deleted the fix-show-progress branch October 31, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants