-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xdebug pipeline #1990
Draft
rvtovar
wants to merge
107
commits into
ubccr:main
Choose a base branch
from
rvtovar:xdebug_pipeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Xdebug pipeline #1990
+8,369
−6,319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added four new scripts responsible for installing & configuring XDebug, generating the code coverage data from php file execution, and generating the final reports. - Updated `shippable.yml` so that XDebug / Code Coverage is only generated during the nightly test build. - Updated numerous UI tests to work more reliably when XDebug is installed ( i.e. their timeouts were increased ) - Updated a couple of UI test selectors to minimize the effects of latency on particular tests. - Added a new webdriverhelper function called `clickSelectorAndWaitForMask` as this was a commonly feature during developing this PR. - Updated the timeout for a few other webdriverhelper functions.
- It was found while running these tests on the CentOS8 image, that the `setupBeforeClass` function was not being called as expected, this small addition will catch if the required `self::$hashFilePath` variable has been set, and if not then run the `setupBeforeClass` function so that it is populated.
- Since we're now running this script on CentOS7|8 and Rocky8.5 containers we need to take into account the different software versions / configuration options that must be set to successfully collect the code coverage data generated by our tests.
By installing Xdebug and setting up code coverage before running bootstrap we'll generate code coverage information for our install / upgrade code including the ETL code.
These changes migrate our current UI test framework from webdriverio to playwright. The reasons for the migration include but are not limited to: - During testing Playwright proved to be more resilient to timining issues than webdriverio. This should mean less failures of CI builds due to timing issues which means less time dealt with timing issue failures during CI builds. - Playwright supports parallel test execution so CI builds end up taking significantly less time. The original ui tests in `tests/ui/*` have been removed as they are no longer needed.
This reverts commit 835e352.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Tests performed
Checklist: