-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin class management (backend) #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjessieshang
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding shift_id to the shifts table will be a big improvement to allow for empty shifts. Thank you Jan for making the adjustment everywhere and also in the ERM diagram.
- Endpoints looks good to me, just need to resolve the merge conflicts
- Next step for your add classes module will be to build the frontend and connect with these endpoints once design is ready :)
LGTM good luck on the monster merge |
theosiemensrhodes
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and added backend functionality for the admin class management module. Merged #42 midway through to make sure new code in the model classes was consistent with the
mysql2
changes.Class Module
PUT
endpoint to allow admins to update classesDELETE
endpoint to delete classes by IDsubcategory
toaddClass()
parameters as it was missingSchedule Module
DELETE
endpoint to delete all schedules included in a given list of schedule IDssetSchedulesByClassId()
where added list of schedules was creating an invalid SQL queryShift Module
shift_id
to shifts table in DB to replace(fk_volunteer_id, fk_schedule_id, shift_date)
as PKshift_coverage_request
in DB to reference shifts usingshift_id
GetShiftsByVolunteerIdAndMonth
procedure inprocedures.sql
to useshift_id
for joins involving shifts tablePOST
,PUT
andDELETE
endpoints in the shifts moduleDon't think any existing functions in the shifts model needed to be updated as a result of the PK change btw.
Tested all the endpoints too and should be good to go