Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump got from 13.0.0 to 14.0.0 in /docs (#75)" #76

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

r-hang
Copy link
Contributor

@r-hang r-hang commented Dec 6, 2023

This reverts commit 9ad160e.

Post merge CI fails, with

yarn install v1.22.21
[1/4] Resolving packages...
[2/4] Fetching packages...
warning [email protected]: Invalid bin field for "url-loader".
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=20". Got "1[6](https://github.com/uber-go/cff/actions/runs/7118151076/job/19380501646#step:4:7).20.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: Process completed with exit code 1.

reverting.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ad160e) 87.20% compared to head (019ae23) 87.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files          32       32           
  Lines        2603     2603           
=======================================
  Hits         2270     2270           
  Misses        269      269           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-hang r-hang merged commit 060d747 into main Dec 6, 2023
6 checks passed
@r-hang r-hang deleted the rhang/revert-got-upgrade branch December 6, 2023 17:55
@abhinav
Copy link
Collaborator

abhinav commented Dec 7, 2023

@r-hang

node-version: '16'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants