golangci: Run install step with --help #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR builds have been failing with an unknown flag error ``` run golangci-lint Running [/home/runner/golangci-lint-1.58.1-linux-amd64/golangci-lint run --version] in [/home/runner/work/cff/cff] ... Error: unknown flag: --version Failed executing command with error: unknown flag: --version ``` ref: https://github.com/uber-go/cff/actions/runs/9061971983/job/24894837626?pr=96 --version is a valid flag for golangci-lint but not golangci-lint run. For golangci-lint run, the closest no-op action is --help. Fix golangci-lint runs by using the --help flag instead of the version flag.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 67.94% 67.94%
=======================================
Files 32 32
Lines 2059 2059
=======================================
Hits 1399 1399
Misses 636 636
Partials 24 24 ☔ View full report in Codecov by Sentry. |
abhinav
approved these changes
May 14, 2024
JacobOaks
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR builds have been failing with an unknown flag error
ref: https://github.com/uber-go/cff/actions/runs/9061971983/job/24894837626?pr=96
--version is a valid flag for golangci-lint but not golangci-lint run.
For golangci-lint run, the closest no-op action is --help.
Fix golangci-lint runs by using the --help flag instead of the version flag.