Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cff ci: make tidy to fix lint step #98

Merged
merged 1 commit into from
May 14, 2024
Merged

cff ci: make tidy to fix lint step #98

merged 1 commit into from
May 14, 2024

Conversation

r-hang
Copy link
Contributor

@r-hang r-hang commented May 14, 2024

CFF CI's lint step failed recently with:

[lint] golangci-lint: .
[lint] golangci-lint: ./examples
[lint] golangci-lint: ./docs
level=error msg="Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem"
make: *** [Makefile:89: golangci-lint] Error 5

I was able to reproduce this error on a linux environment. Running make tidy resolved this specific issue on that environment.

CFF CI failed recently with:
```
[lint] golangci-lint: .
[lint] golangci-lint: ./examples
[lint] golangci-lint: ./docs
level=error msg="Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem"
make: *** [Makefile:89: golangci-lint] Error 5
```

I was able to reproduce with on a linux environment. Running `make tidy`
resolved this specific issue on that environment.
@r-hang r-hang requested review from JacobOaks and abhinav May 14, 2024 22:29
@r-hang r-hang changed the title CFF CI: Run make tidy cff ci: make tidy to fix lint step May 14, 2024
@r-hang r-hang merged commit c5b9eb0 into main May 14, 2024
6 checks passed
@r-hang r-hang deleted the rhang/fix-cff-ci branch May 14, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants