Upgrade Dig to v1.17.1 #1138
Merged
Upgrade Dig to v1.17.1 #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades Fx to use the latest Dig version 1.17.1, which contains a bug fix that would solve issues uber-go#1104 and uber-go#1137 (uber-go/dig#393).
JacobOaks
force-pushed
the
joaks/use_dig_1171
branch
from
85931fe
to
0244512
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 98.80% 98.74% -0.07%
==========================================
Files 36 30 -6
Lines 3106 2948 -158
==========================================
- Hits 3069 2911 -158
Misses 30 30
Partials 7 7 ☔ View full report in Codecov by Sentry. |
sywhang
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Fx to use the latest Dig version 1.17.1,
which contains a bug fix that would solve issues #1104 and #1137
(uber-go/dig#393).