Support optional diff formatter fn for eq #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm keen to see progress on more useful output when expectations fail – e.g. #130 and various historical tickets on the original repo.
PR #154 proposes directly using go-cmp's
cmp.Diff
internally for this purpose. That would be great from my POV. But maintainers have given feedback about change scope and extra dependency.So this is an alternative approach, which tries to assuage those concerns... or at least revive the conversation.
This implements a new Controller option,
WithDiffFormatter
. It takes a function that is called with the expected and actual values, only when theEq
matcher fails. I think this would cover the vast majority of use-cases.This gives users freedom to do what they like, including passing to
cmp.Diff
or a similar lib.I think this is a significant improvement over the status quo:
GotFormatter
andWantFormatter
.