Enable javac -parameters flag (#1069)

This enables Error Prone to discover more issues, e.g., we fix a couple of `assertEquals` argument ordering issues.
uber · Nov 9, 2024 · 0a5fa0f · 0a5fa0f
1 parent 1e9c754
commit 0a5fa0f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/build.gradle b/build.gradle
@@ -61,7 +61,8 @@ subprojects { project ->
             "-Xlint:deprecation",
             "-Xlint:rawtypes",
             "-Xlint:unchecked",
-            "-Werror"
+            "-Werror",
+            "-parameters",
         ]
         options.errorprone {
             // disable warnings in generated code; AutoValue code fails UnnecessaryParentheses check

diff --git a/nullaway/src/test/java/com/uber/nullaway/DummyOptionsConfigTest.java b/nullaway/src/test/java/com/uber/nullaway/DummyOptionsConfigTest.java
@@ -50,7 +50,7 @@ public void allDeclaredMethodsThrowIllegalStateException() {
       Throwable cause = reflectionException.getCause();
       assertThat(cause, instanceOf(IllegalStateException.class));
       IllegalStateException exception = (IllegalStateException) cause;
-      assertEquals(exception.getMessage(), DummyOptionsConfig.ERROR_MESSAGE);
+      assertEquals(DummyOptionsConfig.ERROR_MESSAGE, exception.getMessage());
     }
   }
 }
diff --git a/nullaway/src/test/java/com/uber/nullaway/LegacyAndJspecifyModeTest.java b/nullaway/src/test/java/com/uber/nullaway/LegacyAndJspecifyModeTest.java
@@ -42,6 +42,6 @@ public void testIllegalStateExceptionUsingReflection() throws Exception {
 
     Throwable cause = exception.getCause();
     assertThat(cause, instanceOf(IllegalStateException.class));
-    assertEquals(cause.getMessage(), ERROR);
+    assertEquals(ERROR, cause.getMessage());
   }
 }