Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to resize an existing circle by clicking twice #525

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

StijnAmeloot
Copy link
Contributor

@StijnAmeloot StijnAmeloot commented Feb 14, 2021

By default a circle can now be resized by clicking twice along the ring.
The 'dragToDraw' option has been added to the mode config to enable dragging instead of clicking twice.

Example (shows first the two-click mode and after that the drag to draw mode)
resize-circle-mode3

@coveralls
Copy link

coveralls commented Feb 14, 2021

Pull Request Test Coverage Report for Build 2290

  • 0 of 35 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 22.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/edit-modes/src/lib/resize-circle-mode.ts 0 35 0.0%
Files with Coverage Reduction New Missed Lines %
modules/edit-modes/src/lib/resize-circle-mode.ts 4 0%
Totals Coverage Status
Change from base Build 2287: -0.1%
Covered Lines: 1218
Relevant Lines: 5219

💛 - Coveralls

@StijnAmeloot
Copy link
Contributor Author

Fixed a small issue and added a gif which shows the two different modes.
Please let me know if there is anything that needs to be improved.

@Akiyamka Akiyamka added the feature New feature or request label Dec 19, 2022
Copy link
Collaborator

@igorDykhta igorDykhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think dragToDraw: true should be by default
  2. Not sure how the mode with dragToDraw: false should work. I activated the resizing mode, then I clicked anywhere, no response at this point, then the circle starts to resize with any mouse movement, then I need to click to finish resizing. I assume the resizing should only start after clicking on the small helper circle which appears on the edge of the circle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants