Skip to content

Commit

Permalink
Merge pull request #142 from uber/generator-module_prefix_comp_type-m…
Browse files Browse the repository at this point in the history
…aster

Use NeedleFoundation module prefix for generated code
  • Loading branch information
Rudro Samanta authored Aug 21, 2018
2 parents 6c1082b + db447da commit 8962d0c
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class DependencyProviderSerializer: Serializer {
private class \(classNameSerializer.serialize()): \(provider.unprocessed.dependency.name) {
\(propertiesSerializer.serialize())
\(sourceComponentsSerializer.serialize())
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
\(initBodySerializer.serialize())
}
}\n
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class PluginExtensionContentSerializer: Serializer {
private class \(extensionClassName): \(component.pluginExtension.name) {
\(properties)
private unowned let \(nonCoreComponentPropertyName): \(component.nonCoreComponent.name)
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
let \(pluginziedComponentPropertyName) = component as! \(component.data.name)
\(nonCoreComponentPropertyName) = \(pluginziedComponentPropertyName).nonCoreComponent as! \(component.nonCoreComponent.name)
}
Expand Down
3 changes: 3 additions & 0 deletions Generator/Tests/NeedleFrameworkTests/Fixtures/HeaderDoc.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
//
// Copyright © Uber Technologies, Inc. All rights reserved.
//
// @generated by Needle
// swiftlint:disable custom_rules
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
//
// Copyright © Uber Technologies, Inc. All rights reserved.
//
// @generated by Needle
// swiftlint:disable custom_rules

Expand Down Expand Up @@ -51,7 +54,7 @@ private class LoggedOutDependencyacada53ea78d270efa2fProvider: LoggedOutDependen
return rootComponent.mutablePlayersStream
}
private let rootComponent: RootComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
rootComponent = component.parent as! RootComponent
}
}
Expand All @@ -61,7 +64,7 @@ private class ScoreSheetDependencyea879b8e06763171478bProvider: ScoreSheetDepend
return (loggedInComponent.nonCoreComponent as! LoggedInNonCoreComponent).scoreStream
}
private let loggedInComponent: LoggedInComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent.parent.parent as! LoggedInComponent
}
}
Expand All @@ -71,7 +74,7 @@ private class ScoreSheetDependency6fb80fa6e1ee31d9ba11Provider: ScoreSheetDepend
return loggedInNonCoreComponent.scoreStream
}
private let loggedInNonCoreComponent: LoggedInNonCoreComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInNonCoreComponent = component.parent as! LoggedInNonCoreComponent
}
}
Expand All @@ -85,7 +88,7 @@ private class GameDependency1ab5926a977f706d3195Provider: GameDependency {
}
private let loggedInComponent: LoggedInComponent
private let rootComponent: RootComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent as! LoggedInComponent
rootComponent = component.parent.parent as! RootComponent
}
Expand All @@ -96,7 +99,7 @@ private class GamePluginExtensionProvider: GamePluginExtension {
return gameNonCoreComponent.scoreSheetBuilder
}
private unowned let gameNonCoreComponent: GameNonCoreComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
let gameComponent = component as! GameComponent
gameNonCoreComponent = gameComponent.nonCoreComponent as! GameNonCoreComponent
}
Expand All @@ -110,7 +113,7 @@ private class LoggedInPluginExtensionProvider: LoggedInPluginExtension {
return loggedInNonCoreComponent.mutableScoreStream
}
private unowned let loggedInNonCoreComponent: LoggedInNonCoreComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
let loggedInComponent = component as! LoggedInComponent
loggedInNonCoreComponent = loggedInComponent.nonCoreComponent as! LoggedInNonCoreComponent
}
Expand Down
11 changes: 7 additions & 4 deletions Generator/Tests/NeedleFrameworkTests/Fixtures/generated.swift
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
//
// Copyright © Uber Technologies, Inc. All rights reserved.
//
// @generated by Needle
// swiftlint:disable custom_rules

Expand Down Expand Up @@ -41,7 +44,7 @@ private class GameDependency1ab5926a977f706d3195Provider: GameDependency {
}
private let loggedInComponent: LoggedInComponent
private let rootComponent: RootComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent as! LoggedInComponent
rootComponent = component.parent.parent as! RootComponent
}
Expand All @@ -52,7 +55,7 @@ private class ScoreSheetDependency97f2595a691a56781aaaProvider: ScoreSheetDepend
return loggedInComponent.scoreStream
}
private let loggedInComponent: LoggedInComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent.parent as! LoggedInComponent
}
}
Expand All @@ -62,7 +65,7 @@ private class ScoreSheetDependencycbd7fa4bae2ee69a1926Provider: ScoreSheetDepend
return loggedInComponent.scoreStream
}
private let loggedInComponent: LoggedInComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent as! LoggedInComponent
}
}
Expand All @@ -72,7 +75,7 @@ private class LoggedOutDependencyacada53ea78d270efa2fProvider: LoggedOutDependen
return rootComponent.mutablePlayersStream
}
private let rootComponent: RootComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
rootComponent = component.parent as! RootComponent
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class DependencyProviderSerializerTaskTests: AbstractGeneratorTests {
}
private let loggedInComponent: LoggedInComponent
private let rootComponent: RootComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent as! LoggedInComponent
rootComponent = component.parent.parent as! RootComponent
}
Expand All @@ -84,7 +84,7 @@ class DependencyProviderSerializerTaskTests: AbstractGeneratorTests {
return loggedInComponent.scoreStream
}
private let loggedInComponent: LoggedInComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent.parent as! LoggedInComponent
}
}
Expand All @@ -94,7 +94,7 @@ class DependencyProviderSerializerTaskTests: AbstractGeneratorTests {
return loggedInComponent.scoreStream
}
private let loggedInComponent: LoggedInComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
loggedInComponent = component.parent as! LoggedInComponent
}
}
Expand All @@ -104,7 +104,7 @@ class DependencyProviderSerializerTaskTests: AbstractGeneratorTests {
return rootComponent.mutablePlayersStream
}
private let rootComponent: RootComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
rootComponent = component.parent as! RootComponent
}
}\n
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class PluginExtensionSerializerTaskTests: AbstractPluginizedGeneratorTests {
return gameNonCoreComponent.scoreSheetBuilder
}
private unowned let gameNonCoreComponent: GameNonCoreComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
let gameComponent = component as! GameComponent
gameNonCoreComponent = gameComponent.nonCoreComponent as! GameNonCoreComponent
}
Expand All @@ -73,7 +73,7 @@ class PluginExtensionSerializerTaskTests: AbstractPluginizedGeneratorTests {
return loggedInNonCoreComponent.mutableScoreStream
}
private unowned let loggedInNonCoreComponent: LoggedInNonCoreComponent
init(component: ComponentType) {
init(component: NeedleFoundation.ComponentType) {
let loggedInComponent = component as! LoggedInComponent
loggedInNonCoreComponent = loggedInComponent.nonCoreComponent as! LoggedInNonCoreComponent
}
Expand Down

0 comments on commit 8962d0c

Please sign in to comment.