Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added pyvista visualisation documentation and removed k3d #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added pyvista visualisation documentation and removed k3d #40

wants to merge 2 commits into from

Conversation

kzqureshi
Copy link

No description provided.

@kzqureshi kzqureshi requested a review from lang-m November 13, 2024 12:52
lang-m
lang-m requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@lang-m lang-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove k3d from the webpages yet (it is still part of discretisedfield). Could you please keep the k3d notebook but add a note at the top where you mention that it is deprecated and users should switch to pyvista.

@kzqureshi kzqureshi requested a review from lang-m December 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lang-m lang-m Awaiting requested review from lang-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzqureshi @lang-m