Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add initramfs generation #1127

Merged
merged 14 commits into from
Apr 13, 2024
Merged

feat: Add initramfs generation #1127

merged 14 commits into from
Apr 13, 2024

Conversation

KyleGospo
Copy link
Member

@KyleGospo KyleGospo commented Apr 12, 2024 •
edited
Loading

TODO: Copy files from system_files/nvidia/shared/* into the image only for Nvidia builds

m2Giles
m2Giles reviewed Apr 12, 2024
View reviewed changes
build_files/dx/build-dx.sh Show resolved Hide resolved
build_files/shared/initramfs.sh Show resolved Hide resolved
system_files/shared/usr/lib/dracut/dracut.conf.d/10-compression.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should compare against uncompressed for boot time.

Nvidia likely needs to be compressed for the additional files but non-nvidia initramfs will only be about 40 MB larger.

@KyleGospo
feat: Add initramfs generation
b64dc71 
chore: Add watermark with bluefin branding
TODO: Copy files from system_files/nvidia/shared/* into the image only for Nvidia builds
@noelmiller
Copy link
Member

We will need the watermark to be image specific since Aurora builds out of the same repo. Not sure the best way to accomplish that.

@m2Giles
Copy link
Member

m2Giles commented Apr 13, 2024 •
edited
Loading

Two ideas:

  1. Have the watermark under specific flavor files.

  2. Rename each to branded, depending on name of image rename or symlink to generic watermark name.

I just went with the second idea since we do the branding before initramfs generation.

@KyleGospo KyleGospo marked this pull request as ready for review April 13, 2024 00:44
@noelmiller
Copy link
Member

@KyleGospo @m2Giles have we tested this with ISOs yet? I don't think it should affect the installation, but I am curious about the first startup after installation.

@m2Giles
Copy link
Member

m2Giles commented Apr 13, 2024

The only testing was with Bazzite testing.

Also need to make sure all of the Nvidia stuff is cleaned up. It's still included in -main images.

@KyleGospo
Copy link
Member Author

@m2Giles we'll want to keep the GSP Firmware enablement on all images that aren't Nvidia

@m2Giles m2Giles mentioned this pull request Apr 13, 2024
Closed
@KyleGospo KyleGospo added this pull request to the merge queue Apr 13, 2024
Merged via the queue into main with commit 35f9340 Apr 13, 2024
70 checks passed
@KyleGospo KyleGospo deleted the initramfs branch April 13, 2024 23:21
@github-actions github-actions bot mentioned this pull request Apr 13, 2024
Merged
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
@KyleGospo @m2Giles
feat: Add initramfs generation (ublue-os#1127)
37d2458 
Co-authored-by: m2Giles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castrojo castrojo castrojo approved these changes

@p5 p5 p5 approved these changes

@m2Giles m2Giles m2Giles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleGospo @noelmiller @m2Giles @castrojo @p5