fix: remove duplicate builds on merge queue and push #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've cancelled builds because they are not required for this PR. |
m2Giles
approved these changes
Apr 14, 2024
|
Going to bypass branch protection here. No need for new builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building and pushing to GHCR when a PR is added to a merge queue (
merge_group), and also after the PR has been successfully merged into main (push).To me, this seems like we are running a build when we do not need to, and unnecessarily taking up GHA runners.
This PR removes the builds after a commit has been merged to
mainandtestingsince these are ran during merge queue.