-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable stable-daily channel #1779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good:
- scheduled daily build of "stable" will result in tags:
stable-daily
andstable-daily-TIMESTAMP
- scheduled weekly build of "stable" will result in tags:
stable-daily
,stable-daily-TIMESTAMP
,stable
,stable-TIMESTAMP
- manual build will result in tags:
stable-daily
,stable-daily-TIMESTAMP
,stable
,stable-TIMESTAMP
In all cases the "DEFAULT_TAG" is stable-daily
which i think is correct.
This is awesome, thank you for this! |
oh sweeeeet! |
Thank you for adding this! |
@castrojo per our real-time chat, i think we may want an improvement where we can do a manual build which only regenerates a "stable-daily" and not a "stable-weekly" but that would also require a workflow specifically for the semi-rare scenarios where you need to manually build a weekly... and that would be extra logic in the tags. |
Nice, now live from stable-daily! Let's see how this works out. Oh I now see that it has been building iso's too. I'm not sure where that comes from as I didn't touch iso workflows. 😕 bluefin/.github/workflows/reusable-build.yml Line 546 in 3201dd3
Well, I'm really sorry, but I'm unable to fix the ISO building. There are too many variables that I'm not comfortable enough with. Therefore, it might be better to revert this PR before it consumes all the resources. |
Don't sweat the ISOs we can go back and clean those up, it's not burning through money. Though nothing got pushed to the bucket afaict. (On stable-daily here too, nice!) |
Ok so I totally love how this is working out. I keep my main PC on stable-daily because I gotta always have everything, but then keep the rest of my PCs on stable because that's also fine. It's like a little sports mode button. 😈 |
Same here! Desktop pc on stable-daily and laptop on stable. Feels like the perfect combination. |
I really liked the idea of having a daily build of the stable channel as of talked in #1736. So I tried my best to implement this feature.
Changes made:
Hope this is the correct implementation, thanks for this awesome project.