-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply theming updates & enable xwayland scaling #1813
Conversation
Remove Yaru default themes Set Inter & JetBrains Mono font Apply blur to dock Enable xwayland native scaling Set slate accent color
@@ -77,7 +75,7 @@ sort-directories-first=true | |||
sort-directories-first=true | |||
|
|||
[org.gnome.mutter] | |||
experimental-features=['scale-monitor-framebuffer'] | |||
experimental-features=['scale-monitor-framebuffer', 'xwayland-native-scaling'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this value cause an issue on Gnome 40?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I could tell. It just sits unused in versions <47
monospace-font-name="Ubuntu Mono 18" | ||
font-name="Inter 12" | ||
document-font-name="Inter 12" | ||
monospace-font-name="JetBrains Mono 18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still use size 18 font by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it at 18 since it was like that before. I'm not opposed to changing this if we feel it's better suited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I picked that based on my own aging eyeballs, we should pick whatever the best default should be.
@@ -31,7 +31,7 @@ if [[ "${BASE_IMAGE_NAME}" = "silverblue" ]]; then | |||
find /usr/share/glib-2.0/schemas/ -type f ! -name "*.gschema.override" -exec cp {} /tmp/bluefin-schema-test/ \; | |||
cp /usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override /tmp/bluefin-schema-test/ | |||
echo "Running error test for bluefin gschema override. Aborting if failed." | |||
glib-compile-schemas --strict /tmp/bluefin-schema-test | |||
glib-compile-schemas /tmp/bluefin-schema-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference with having --strict removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--strict is causing issues in GNOME <47 since the accent color dconf key doesn't exist in these lower versions. The flag causes any errors in the dconf to fail, whereas without it, those problematic keys are just excluded from the compiled data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you omit --strict
from here, you destroy the purpose of running this test.
But it's a good point that this gschema test should handle lower Gnome versions better.
So maybe this can be temporarily removed, then put back when this logic gets revamped to support gschema checking for both :gts
& :latest
? Would be good to comment that here.
This pull request includes several changes to configuration files and package lists to update settings and dependencies. The most important changes involve modifying schema overrides, updating package lists, and adjusting error handling in a script.
Schema overrides updates:
system_files/silverblue/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override
: Updated font settings to use "Inter" and "JetBrains Mono" fonts, addedaccent-color
, and included new experimental features for GNOME Mutter. [1] [2] [3] [4]Package list updates:
packages.json
: Addedjetbrains-mono-fonts-all
and removedjetbrains-mono-fonts-all
from a different section to ensure correct categorization. [1] [2]Script error handling adjustment:
build_files/bluefin-changes.sh
: Removed the--strict
flag from theglib-compile-schemas
command to prevent script abortion on non-critical errors.