Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply theming updates & enable xwayland scaling #1813

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

p5
Copy link
Member

@p5 p5 commented Oct 20, 2024

This pull request includes several changes to configuration files and package lists to update settings and dependencies. The most important changes involve modifying schema overrides, updating package lists, and adjusting error handling in a script.

Schema overrides updates:

Package list updates:

  • packages.json: Added jetbrains-mono-fonts-all and removed jetbrains-mono-fonts-all from a different section to ensure correct categorization. [1] [2]

Script error handling adjustment:

Remove Yaru default themes
Set Inter & JetBrains Mono font
Apply blur to dock
Enable xwayland native scaling
Set slate accent color
@p5 p5 requested a review from castrojo as a code owner October 20, 2024 15:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Oct 20, 2024
@p5 p5 changed the title feat: apply theming updates feat: apply theming updates & enable xwayland scaling Oct 22, 2024
@@ -77,7 +75,7 @@ sort-directories-first=true
sort-directories-first=true

[org.gnome.mutter]
experimental-features=['scale-monitor-framebuffer']
experimental-features=['scale-monitor-framebuffer', 'xwayland-native-scaling']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this value cause an issue on Gnome 40?

Copy link
Member Author

@p5 p5 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I could tell. It just sits unused in versions <47

monospace-font-name="Ubuntu Mono 18"
font-name="Inter 12"
document-font-name="Inter 12"
monospace-font-name="JetBrains Mono 18"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still use size 18 font by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it at 18 since it was like that before. I'm not opposed to changing this if we feel it's better suited.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I picked that based on my own aging eyeballs, we should pick whatever the best default should be.

@@ -31,7 +31,7 @@ if [[ "${BASE_IMAGE_NAME}" = "silverblue" ]]; then
find /usr/share/glib-2.0/schemas/ -type f ! -name "*.gschema.override" -exec cp {} /tmp/bluefin-schema-test/ \;
cp /usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override /tmp/bluefin-schema-test/
echo "Running error test for bluefin gschema override. Aborting if failed."
glib-compile-schemas --strict /tmp/bluefin-schema-test
glib-compile-schemas /tmp/bluefin-schema-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference with having --strict removed?

Copy link
Member Author

@p5 p5 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--strict is causing issues in GNOME <47 since the accent color dconf key doesn't exist in these lower versions. The flag causes any errors in the dconf to fail, whereas without it, those problematic keys are just excluded from the compiled data.

Copy link
Collaborator

@fiftydinar fiftydinar Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you omit --strict from here, you destroy the purpose of running this test.

But it's a good point that this gschema test should handle lower Gnome versions better.

So maybe this can be temporarily removed, then put back when this logic gets revamped to support gschema checking for both :gts & :latest? Would be good to comment that here.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2024
@castrojo castrojo added this pull request to the merge queue Oct 24, 2024
@castrojo castrojo removed this pull request from the merge queue due to a manual request Oct 24, 2024
@castrojo castrojo merged commit 87d8c97 into main Oct 24, 2024
61 of 66 checks passed
@castrojo castrojo deleted the theme-changes branch October 24, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants