feat: Update VFIO to be bootc compliant #2150
Conversation
It is a tool that lists pci devices and which groups they are in, and it lets you use flags to fine tune what you look for and what info you want.
dosubot
bot
added
size:M
| @@ -195,9 +195,6 @@ configure-vfio ACTION="": | |||
| echo "$VFIO_IDS" | |||
| VFIO_IDS_KARG="--delete-if-present=\"$VFIO_IDS\"" | |||
| fi | |||
| echo "Removing dracut modules" | |||
| sudo rm /etc/dracut.conf.d/vfio.conf | |||
| rpm-ostree initramfs --enable | |||
| rpm-ostree kargs \ | |||
There was a problem hiding this comment.
Can we still run kargs on a bootc-only system?
There was a problem hiding this comment.
we use it in bazzite, bootc just does not like the initramfs rebuilding and layering from my understanding.
but i can remove lact from my install and double check to be 100% sure
There was a problem hiding this comment.
just checked, can be used with kargs, just not layers and initramfs
| options kvmfr static_size_mb=128 | ||
| KVMFR_MODPROBE" | ||
| # Add kvmfr static size karg | ||
| rpm-ostree kargs --append-if-missing="kvmfr.static_size_mb=128" |
There was a problem hiding this comment.
Using the modprobe override here seems like what we should do with bootc, but maybe it just works?
There was a problem hiding this comment.
we probably can and the looking-glass people would prefer it over using rpm-ostree kargs which is unique to fedora atomic, i am just following the change kyle did in bazzite to add the vfio modules to the image. :)
|
putting back to draft as i remembered there is a part i forgot to move over from bazzite, so will work on that later today or in the weekend hopefully |
This will be kept as a draft in-case more changes are needed, but from what i can tell, dracut is being run as part of the build process so the vfio modules should be included into initramfs with the image with this inclusion.
the just recipes and the script for kvmfr has been updated to reflect this
also minor changes to heredocs in some recipes to make the just highlighting work for me in vscode when writing this.
I will be making a similar PR to Aurora with the same updates later.