chore: cleanup fonts #2200
Draft
chore: cleanup fonts #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All these fonts can be installed by the user with embellish (included as a flatpak in the dx image) I'm keeping opendyslexic for a11y, and cascadia, since it is set as the default font in our vscode config
it is used as the default monospace font
also available through embellish
dosubot
bot
added
size:L
|
This just removes all the fonts? I thought we were moving the fonts to RPMs instead of individual files? |
|
I didn't see the point in having half a dozen additional fonts in DX when we are already shipping Embellish, but as I said, I'm open to restoring in this PR whatever fonts are most popular. |
|
Yes we still want to ship the fonts, "A collection of well-curated monospace fonts" is one of the major features of DX, and the ubuntu font in particular is part of our identity. By "clean up" we mean centralizing the fonts in the packages repo so that the font installation is consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes from the image all the fonts that can be installed with Embellish, while keeping those used in default configs (such as JetBrains Mono or Cascadia Code). It also installs Inter as an RPM.
I've been as aggressive as I can be removing fonts without affecting the default experience, I'm open to modifying the PR if one font is particularly popular.
Closes #2190
Works towards #2039