-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ADSys arch explanation #1177
Conversation
- mermaid sources in diagrams directory - readme to explain use of diagrams - explanation page for ref arch
just to pass the spellchecker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed, separated, commits!
I only have one question, nothing on the rest. Ofc, I couldn’t check the mermaid diagrams as there is no rendering here, but we can always iterate over them.
changes "AD client" to "Ubuntu machine" in arch diagrams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a small nitpick...
PS.: Sorry, I added the nitpick on this conversation
@denisonbarbosa -- just to clarify, are you suggesting replacing all instances of "policies" with "GPOs"? For example, we would have: "fetch GPOs" and "relevant GPOs applied". I would agree with that change for consistency. |
Exactly. Either that or the other way around (replacing GPOs w/ policies or group policies). Whatever you think is going to be clearer. |
@didrocks -- I addressed your comment in 10458bb @denisonbarbosa -- your suggestion was applied in 2388ee4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Everything looks great now!
PR #1177 introduced a new .md file in docs/diagrams. However, this file is a guide as to how to use the diagram tooling rather than adsys documentation, so we need to ignore that directory as well in the test checks.
PR #1177 introduced a new .md file in docs/diagrams. However, this file is a guide to how to use the diagram tooling rather than adsys documentation, so we need to ignore that directory as well in the test checks.
Adds an architecture explanation for ADSys to the documentation, including a discussion of SSSD's role.
Mermaid is used for rendering the diagrams, which required an extension.
Other minor changes:
UDENG-5808