Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SearchBar autofocus when click on clear btn #1796

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

MrSIHAB
Copy link
Contributor

@MrSIHAB MrSIHAB commented Aug 24, 2024

The search bar should automatically focused when 'clear search text' button is clicked. This is small tweak but usefull too. I do search, do some activities. Then search bar become unfocused. Then I click on clear search button and start typing my query, And then I see that Search bar is not focused. I have to manually click on the textfeild to focus it. This pull request will automatically focus search bar when someone click on clear search button. I made this changes from my experience.

The search bar should automatically focused when 'clear search text' button is clicked. This is small tweak but usefull too.
I do search, do some activities. Then search bar become unfocused. Then I click on clear search button and start typing my query, And then I see that Search bar is not focused. I have to manually click on the textfeild to focus it. This pull request will automatically focus search bar when someone click on clear search button. I made this changes from my experience.
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run dart format to format the code properly. :)

packages/app_center/lib/search/search_field.dart Outdated Show resolved Hide resolved
@spydon spydon changed the title improved: SearchBar autofocus when click on clear btn fix: SearchBar autofocus when click on clear btn Aug 28, 2024
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed up the formatting, so now it looks shippable!

@spydon spydon merged commit bd16df1 into ubuntu:main Aug 28, 2024
8 checks passed
@MrSIHAB
Copy link
Contributor Author

MrSIHAB commented Sep 17, 2024

Thanks. Next time I'll take care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants