Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clickable categories #1799

Merged
merged 8 commits into from
Aug 30, 2024
Merged

feat: Clickable categories #1799

merged 8 commits into from
Aug 30, 2024

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Aug 27, 2024

Screencast.from.2024-08-27.13-20-23.webm

Closes: #1771

@spydon
Copy link
Collaborator Author

spydon commented Aug 27, 2024

Can you check the colors and style of the categories that we want here @anasereijo, when you have time?
It feels like it might be hard to understand that the categories are clickable now.

@spydon spydon force-pushed the feat/clickable-categories branch from 2a1f464 to 7862e67 Compare August 27, 2024 11:38
@anasereijo
Copy link
Collaborator

LGTM

MrSIHAB and others added 7 commits August 30, 2024 11:22
The search bar should automatically focused when 'clear search text' button is clicked. This is small tweak but usefull too.
I do search, do some activities. Then search bar become unfocused. Then I click on clear search button and start typing my query, And then I see that Search bar is not focused. I have to manually click on the textfeild to focus it. This pull request will automatically focus search bar when someone click on clear search button. I made this changes from my experience.
@spydon spydon requested a review from d-loose August 30, 2024 09:23
Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@spydon spydon merged commit 367cacb into main Aug 30, 2024
8 checks passed
@spydon spydon deleted the feat/clickable-categories branch August 30, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category should be clickable on the snap page
4 participants