tests(nss/testutils): Update coverage generation and merging #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibel
reviewed
Nov 10, 2023
denisonbarbosa
force-pushed
the
test-coverage-updates
branch
from
3fe634c to
eabaee5
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
jibel
reviewed
Nov 10, 2023
denisonbarbosa
force-pushed
the
test-coverage-updates
branch
from
eabaee5 to
47f2a6e
Compare
didrocks
requested changes
Nov 16, 2023
@didrocks Yeah, I thought |
denisonbarbosa
commented
Nov 20, 2023
denisonbarbosa
commented
Nov 20, 2023
didrocks
approved these changes
Nov 20, 2023
With the tools added in Go 1.20, some of the helpers we had aren't necessary anymore so we can clean them up.
Coverage collection and merging will be done by our test script, so we can clean the source code.
We already have this tool for a while now, but it was not a part of the repository. Since some changes were made to it to update the way we gather the coverage, it should be added to the repo (even if temporarily)
We updated the way we collect the test coverage, so the CI workflow should reflect this as well.
denisonbarbosa
force-pushed
the
test-coverage-updates
branch
from
55e4c3b to
47bf0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Go 1.20, we now have more tools to handle coverage data and binary instrumentation so we should adapt our existing helpers to use those tools. By using them, we can simplify the code and reduce the maintenance load that was imposed by the old helpers.
Tests now should be run with the
gotestcovscript added in this PR. It runs the tests with all the required flags to enable coverage and runs additional commands to convert the Go raw coverage files totextfmtformat, merge the Rust coverage into it and then show the results.UDENG-1679