Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(testutils): Fix logic error when gathering Rust coverage #111

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix(testutils): Fix logic error when gathering Rust coverage #111

merged 1 commit into from
Nov 23, 2023

Conversation

denisonbarbosa
Copy link
Member

We were always instrumenting the Rust binaries, since the CoverDir() was never empty.

@denisonbarbosa denisonbarbosa marked this pull request as ready for review November 23, 2023 13:00
@denisonbarbosa denisonbarbosa requested a review from a team as a code owner November 23, 2023 13:00
didrocks
didrocks approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, only focusing on coverage, we always covered you!

@denisonbarbosa denisonbarbosa merged commit 9dfd621 into main Nov 23, 2023
5 checks passed
@denisonbarbosa denisonbarbosa deleted the fix-coverage-testutils branch November 23, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

@GabrielNagy GabrielNagy GabrielNagy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denisonbarbosa @didrocks @GabrielNagy