perf: continue if active UID is not a real user #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In chroot environments where /proc is mounted it's common to have processes owned by UIDs that do not exist within the chroot. I think getting the active users list should be a best effort approach where we don't fail hard if we cannot do this mapping for an user, mainly because it's highly likely for that user to not be in the DB we want to clean up anyway.
GabrielNagy
force-pushed
the
continue-on-invalid-user
branch
from
9896348 to
74daa42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chroot environments where
/procis mounted it's common to have processes owned by UIDs that do not exist within the chroot.I think getting the active users list should be a best effort approach where we don't fail hard if we cannot do this mapping for an user, mainly because it's highly likely for that user to not be in the DB we want to clean up anyway.
I haven't added a test for this because we don't currently mock
/proc, and based on Denis' feedback this will be refactored in the near future.