pam/gdm/extension: Add PAM gdm JSON extension protocol implementation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 88.14% 88.62% +0.47%
==========================================
Files 32 34 +2
Lines 2430 2532 +102
==========================================
+ Hits 2142 2244 +102
Misses 221 221
Partials 67 67 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
requested changes
Dec 1, 2023
3v1n0
force-pushed
the
gdm-binary-protocol
branch
from
f1ccd43 to
b14c161
Compare
3v1n0
force-pushed
the
gdm-binary-protocol
branch
from
b4088b3 to
9f805d7
Compare
denisonbarbosa
approved these changes
Dec 6, 2023
GabrielNagy
reviewed
Dec 6, 2023
Add go bindings to encode and decode PAM binary messages using the GDM Custom JSON protocol. The protocol will be available as part of GNOME 46, but for being early consumers we include in the repo the headers where the messages are defined, until that's possible to switch on the repo version. See: https://gitlab.gnome.org/GNOME/gdm/-/merge_requests/227
…nary protocol Add an utility function to perform GDM-PAM binary conversations using the custom JSON protocol. This function does not much per se, but it allows us to do some proper testing via the dummy module transaction and so we can test how this data is passed back and forth the two sides, and stress the C <-> go structures conversions.
3v1n0
force-pushed
the
gdm-binary-protocol
branch
from
5b16b2a to
ae93edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add go bindings to encode and decode PAM binary messages using the GDM
Custom JSON protocol.
The protocol will be available as part of GNOME 46, but for being early
consumers we include in the repo the headers where the messages are
defined, until that's possible to switch on the repo version.
See: https://gitlab.gnome.org/GNOME/gdm/-/merge_requests/227