Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: give explicit PR permissions to GitHub token #141

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

GabrielNagy
Copy link
Contributor

When dependabot triggers a PR the GITHUB_TOKEN is read-only and must explicitly be given write permissions. This is a side effect of upgrading to the v5 create-pull-request-action.

Explicitly set these in the workflow to avoid it failing on commits by dependabot, but also to more clearly define the workflow's expected permissions.

When dependabot triggers a PR the GITHUB_TOKEN is read-only and must
explicitly be given write permissions.[1] This is a side effect of
upgrading to the v5 create-pull-request-action.

Explicitly set these in the workflow to avoid it failing on commits by
dependabot, but also to more clearly define the workflow's expected
permissions.

[1] peter-evans/create-pull-request#1873
@GabrielNagy GabrielNagy requested a review from a team as a code owner December 12, 2023 16:13
Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GabrielNagy GabrielNagy merged commit b61d4c8 into main Dec 12, 2023
5 checks passed
@GabrielNagy GabrielNagy deleted the create-pr-explicit-permissions branch December 12, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants