pam/gdm: Keep debugging all the events, sanitizing them if needed #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 84.43% 84.19% -0.24%
==========================================
Files 79 79
Lines 7040 7066 +26
Branches 75 75
==========================================
+ Hits 5944 5949 +5
- Misses 762 785 +23
+ Partials 334 332 -2 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
requested changes
Oct 3, 2024
denisonbarbosa
approved these changes
Oct 3, 2024
3v1n0
force-pushed
the
gdm-debugging-mode
branch
from
95897b6 to
ccd4e8f
Compare
…debug mode Instead of hiding the content authentication data completely, show the whole challenge when `pam_gdm_debug` build tag is used, or when in testing mode. Otherwise, just show a sanitized challenge so that we don't miss the fact that the event has happened Fixes: ca47562
In case the gdm data poll response has content, it's still something we want to show, even though we should sanitize the value when it contains the challenge secret Fixes: 40fa85d
3v1n0
force-pushed
the
gdm-debugging-mode
branch
from
ccd4e8f to
c608853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hiding the content authentication data completely, show the
whole challenge when
pam_gdm_debugbuild tag is used, or when intesting mode.
Otherwise, just show a sanitized challenge so that we don't miss the
fact that the event has happened.
In the same way, keep the conversation debugging alive so that we don't miss pieces of what we got from GDM if the content is relevant.
To sanitize the JSON I preferred to go wild and just replace the content, since it's still something happening only when debugging only, so not really something in production code.
Fixes: ca47562, 40fa85d