maint(pam/integration-tests): Cleanup tests code reducing duplicates and add some docs #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 84.53% 84.14% -0.39%
==========================================
Files 79 80 +1
Lines 7036 7072 +36
Branches 75 75
==========================================
+ Hits 5948 5951 +3
- Misses 759 792 +33
Partials 329 329 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
approved these changes
Oct 3, 2024
3v1n0
force-pushed
the
pam-cleanup-integration-dups
branch
2 times, most recently
from
53413fb to
d46eb62
Compare
We've lots of similar code that is hard to maintain in the VHS tests, so factorize it and use the same helpers in all the tests to manage the VHS setup and launch.
These are not related to the cli tests anymore
It's not something that we need to build by default, being used only by tests or for manual testing, so move it out from pam folder since it doesn't need to access to any pam-private stuff either
We've two types of clients: - The PAM Application Test Client that is used to start a PAM transaction And now we refer to it as the PAM Runner. - The PAM Exec Child Client that is the app implementing the PAM module API through DBus. So hopefully clarify this
…bility Adding new options or settings to a test makes it hard to read, so split the test cases to be in multi-line mode
3v1n0
force-pushed
the
pam-cleanup-integration-dups
branch
from
d46eb62 to
efa8336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had almost equal tests definitions for integration tests using VHS, and since we're just about to add some more, it's time to try to factorize the code so that we don't end up having 3 times the same code being repeated, with all the maintenance issues we know.
So: