Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: remove repeated line under getting started #571

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

shiv-tyagi
Copy link
Contributor

Hi! I found this repeated line while going through the contributing guide. This PR removes the same.

I am new here. I found this project really interesting. Looking forward to making meaningful contributions to the project.

@shiv-tyagi shiv-tyagi requested a review from a team as a code owner October 3, 2024 17:12
Copy link

github-actions bot commented Oct 3, 2024

Everyone contributing to this PR have now signed the CLA. Thanks!

@shiv-tyagi
Copy link
Contributor Author

Couldn't figure out what to fill in here while signing the Canonical CLA. Can anyone please help me with this?

image

@3v1n0
Copy link
Collaborator

3v1n0 commented Oct 3, 2024

Oh, you can likely mention @didrocks there

@shiv-tyagi shiv-tyagi force-pushed the fix-contributing-doc branch from 4d3f803 to fc4275e Compare October 4, 2024 14:42
@shiv-tyagi
Copy link
Contributor Author

Thanks @3v1n0. I've signed the CLA. Can you please review this or redirect it to the right person?

Thanks in advance!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (b252fc7) to head (fc4275e).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   84.13%   83.81%   -0.33%     
==========================================
  Files          79       80       +1     
  Lines        7066     7098      +32     
  Branches       75       75              
==========================================
+ Hits         5945     5949       +4     
- Misses        786      818      +32     
+ Partials      335      331       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@edibotopic edibotopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution @shiv-tyagi -- well spotted!

@edibotopic edibotopic merged commit 87a34c4 into ubuntu:main Oct 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants