Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(pam/pwquality): Protect access to pwquality calls with a mutex #581

Merged
merged 1 commit into from
Oct 10, 2024
Merged

maint(pam/pwquality): Protect access to pwquality calls with a mutex #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pam/internal/adapter/pwquality_c.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,17 @@ import "C"
import (
"errors"
"fmt"
"sync"
"unsafe"
)

var challengeQualityMu sync.Mutex

// checkChallengeQuality checks the quality of the new password using the pwquality library.
func checkChallengeQuality(old, new string) error {
challengeQualityMu.Lock()
defer challengeQualityMu.Unlock()

pwq := C.pwquality_default_settings()
if pwq == nil {
return errors.New("could not allocate pw quality default settings")
Expand Down
Loading